(iceberg) branch main updated: Arrow: Deprecate unused fixed width binary reader classes (#11292)

[etudenhoefner]

This is an automated email from the ASF dual-hosted git repository.

etudenhoefner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 12ff959cc3 Arrow: Deprecate unused fixed width binary reader classes 
(#11292)
12ff959cc3 is described below

commit 12ff959cc366a93af3feb7be4008be5b7428621b
Author: Wing Yew Poon <wyp...@cloudera.com>
AuthorDate: Sun Oct 13 22:53:40 2024 -0700

    Arrow: Deprecate unused fixed width binary reader classes (#11292)
---
 .../arrow/vectorized/parquet/VectorizedColumnIterator.java        | 8 ++++++++
 .../parquet/VectorizedDictionaryEncodedParquetValuesReader.java   | 8 ++++++++
 .../iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java  | 7 +++++++
 .../parquet/VectorizedParquetDefinitionLevelReader.java           | 8 ++++++++
 4 files changed, 31 insertions(+)

diff --git 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
index 822ca8973f..54445e4245 100644
--- 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
+++ 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
@@ -214,6 +214,10 @@ public class VectorizedColumnIterator extends 
BaseColumnIterator {
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public class FixedWidthTypeBinaryBatchReader extends BatchReader {
     @Override
     protected int nextBatchOf(
@@ -278,6 +282,10 @@ public class VectorizedColumnIterator extends 
BaseColumnIterator {
     return new VarWidthTypeBatchReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public FixedWidthTypeBinaryBatchReader fixedWidthTypeBinaryBatchReader() {
     return new FixedWidthTypeBinaryBatchReader();
   }
diff --git 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
index 21670f6b2b..4499d05368 100644
--- 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
+++ 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
@@ -141,6 +141,10 @@ public class VectorizedDictionaryEncodedParquetValuesReader
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   class FixedWidthBinaryDictEncodedReader extends BaseDictEncodedReader {
     @Override
     protected void nextVal(
@@ -203,6 +207,10 @@ public class VectorizedDictionaryEncodedParquetValuesReader
     return new DoubleDictEncodedReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public FixedWidthBinaryDictEncodedReader fixedWidthBinaryDictEncodedReader() 
{
     return new FixedWidthBinaryDictEncodedReader();
   }
diff --git 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
index 7c862d4c3f..d36521273d 100644
--- 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
+++ 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
@@ -421,7 +421,10 @@ public class VectorizedPageIterator extends 
BasePageIterator {
    * Method for reading batches of fixed width binary type (e.g. BYTE[7]). 
Spark does not support
    * fixed width binary data type. To work around this limitation, the data is 
read as fixed width
    * binary from parquet and stored in a {@link VarBinaryVector} in Arrow.
+   *
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
    */
+  @Deprecated
   class FixedWidthBinaryPageReader extends BasePageReader {
     @Override
     protected void nextVal(
@@ -496,6 +499,10 @@ public class VectorizedPageIterator extends 
BasePageIterator {
     return new VarWidthTypePageReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   FixedWidthBinaryPageReader fixedWidthBinaryPageReader() {
     return new FixedWidthBinaryPageReader();
   }
diff --git 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
index 2d2412c550..e8ec7bee8f 100644
--- 
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
+++ 
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
@@ -493,6 +493,10 @@ public final class VectorizedParquetDefinitionLevelReader
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   class FixedWidthBinaryReader extends BaseReader {
     @Override
     protected void nextVal(
@@ -732,6 +736,10 @@ public final class VectorizedParquetDefinitionLevelReader
     return new TimestampInt96Reader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   FixedWidthBinaryReader fixedWidthBinaryReader() {
     return new FixedWidthBinaryReader();
   }