This is an automated email from the ASF dual-hosted git repository. xuanwo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/iceberg-cpp.git
The following commit(s) were added to refs/heads/main by this push: new 33f2a8a fix: Minor typo fixes (#115) 33f2a8a is described below commit 33f2a8ad3bc82209f83ff82f58530d58b1ab6b6f Author: mwish <maplewish...@gmail.com> AuthorDate: Wed Jun 4 14:00:23 2025 +0800 fix: Minor typo fixes (#115) Co-authored-by: xuwei.fu <xuwei...@clickzetta.com> --- src/iceberg/manifest_list.cc | 2 +- src/iceberg/manifest_list.h | 2 +- src/iceberg/snapshot.h | 2 +- src/iceberg/table_metadata.h | 8 +++++--- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/iceberg/manifest_list.cc b/src/iceberg/manifest_list.cc index a0cf205..e85c421 100644 --- a/src/iceberg/manifest_list.cc +++ b/src/iceberg/manifest_list.cc @@ -27,7 +27,7 @@ namespace iceberg { const StructType& PartitionFieldSummary::Type() { static const StructType kInstance{{ - PartitionFieldSummary::kConsTainsNull, + PartitionFieldSummary::kContainsNull, PartitionFieldSummary::kContainsNaN, PartitionFieldSummary::kLowerBound, PartitionFieldSummary::kUpperBound, diff --git a/src/iceberg/manifest_list.h b/src/iceberg/manifest_list.h index 672b36c..ddcc38f 100644 --- a/src/iceberg/manifest_list.h +++ b/src/iceberg/manifest_list.h @@ -52,7 +52,7 @@ struct ICEBERG_EXPORT PartitionFieldSummary { /// values are null or NaN std::optional<std::vector<uint8_t>> upper_bound; - inline static const SchemaField kConsTainsNull = + inline static const SchemaField kContainsNull = SchemaField::MakeRequired(509, "contains_null", std::make_shared<BooleanType>(), "True if any file has a null partition value"); inline static const SchemaField kContainsNaN = diff --git a/src/iceberg/snapshot.h b/src/iceberg/snapshot.h index 924f522..2df6a44 100644 --- a/src/iceberg/snapshot.h +++ b/src/iceberg/snapshot.h @@ -234,7 +234,7 @@ struct ICEBERG_EXPORT DataOperation { struct ICEBERG_EXPORT Snapshot { static constexpr int64_t kInvalidSnapshotId = -1; - /// A unqiue long ID. + /// A unique long ID. int64_t snapshot_id; /// The snapshot ID of the snapshot's parent. Omitted for any snapshot with no parent. std::optional<int64_t> parent_snapshot_id; diff --git a/src/iceberg/table_metadata.h b/src/iceberg/table_metadata.h index 1248314..9c7f37d 100644 --- a/src/iceberg/table_metadata.h +++ b/src/iceberg/table_metadata.h @@ -69,9 +69,11 @@ struct ICEBERG_EXPORT MetadataLogEntry { /// \brief Represents the metadata for an Iceberg table /// /// Note that it only contains table metadata from the spec. Compared to the Java -/// implementation, missing pieces including: 1) Map<Integer, -/// Schema|PartitionSpec|SortOrder> 2) List<MetadataUpdate> 3) Map<Long, Snapshot> 4) -/// Map<String, SnapshotRef> +/// implementation, missing pieces including: +/// (1) Map<Integer, Schema|PartitionSpec|SortOrder> +/// (2) List<MetadataUpdate> +/// (3) Map<Long, Snapshot> +/// (4) Map<String, SnapshotRef> struct ICEBERG_EXPORT TableMetadata { static constexpr int8_t kDefaultTableFormatVersion = 2; static constexpr int8_t kSupportedTableFormatVersion = 3;