This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
The following commit(s) were added to refs/heads/main by this push:
new 79f28ff1 fix: await get catalog in datafusion integration test (#1635)
79f28ff1 is described below
commit 79f28ff1d83d4c192b2acfc29fc87362015f7210
Author: Leon Lin <lianglin....@gmail.com>
AuthorDate: Sun Aug 31 20:40:12 2025 -0700
fix: await get catalog in datafusion integration test (#1635)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
* Previous #1600 added few integration tests, but need to include the
new changes introduced in memory catalog loader change #1623 .
* This caused build failures
## Are these changes tested?
Yes, existing tests
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
---
bindings/python/pyproject.toml | 2 +-
bindings/python/tests/test_datafusion_table_provider.py | 4 ++--
crates/integrations/datafusion/tests/integration_datafusion_test.rs | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/bindings/python/pyproject.toml b/bindings/python/pyproject.toml
index 7b2d3d59..346ee168 100644
--- a/bindings/python/pyproject.toml
+++ b/bindings/python/pyproject.toml
@@ -44,7 +44,7 @@ python-source = "python"
ignore = ["F403", "F405"]
[tool.hatch.envs.dev]
-dependencies = ["maturin>=1.0,<2.0", "pytest>=8.3.2", "pyarrow>=17.0.0",
"datafusion>=45", "pyiceberg[sql-sqlite]>=0.9.1"]
+dependencies = ["maturin>=1.0,<2.0", "pytest>=8.3.2", "pyarrow==16.*",
"datafusion==47.*", "pyiceberg[sql-sqlite]>=0.9.1"]
[tool.hatch.envs.dev.scripts]
build = "maturin build --out dist --sdist"
diff --git a/bindings/python/tests/test_datafusion_table_provider.py
b/bindings/python/tests/test_datafusion_table_provider.py
index 915b7876..5c6a15eb 100644
--- a/bindings/python/tests/test_datafusion_table_provider.py
+++ b/bindings/python/tests/test_datafusion_table_provider.py
@@ -27,8 +27,8 @@ from pathlib import Path
import datafusion
assert (
- datafusion.__version__ >= "45"
-) # iceberg table provider only works for datafusion >= 45
+ datafusion.__version__ >= "47"
+) # iceberg table provider only works for datafusion >= 47
@pytest.fixture(scope="session")
diff --git
a/crates/integrations/datafusion/tests/integration_datafusion_test.rs
b/crates/integrations/datafusion/tests/integration_datafusion_test.rs
index c079dce8..cb2809d0 100644
--- a/crates/integrations/datafusion/tests/integration_datafusion_test.rs
+++ b/crates/integrations/datafusion/tests/integration_datafusion_test.rs
@@ -440,7 +440,7 @@ async fn test_metadata_table() -> Result<()> {
#[tokio::test]
async fn test_insert_into() -> Result<()> {
- let iceberg_catalog = get_iceberg_catalog();
+ let iceberg_catalog = get_iceberg_catalog().await;
let namespace = NamespaceIdent::new("test_insert_into".to_string());
set_test_namespace(&iceberg_catalog, &namespace).await?;
@@ -553,7 +553,7 @@ fn get_nested_struct_type() -> StructType {
#[tokio::test]
async fn test_insert_into_nested() -> Result<()> {
- let iceberg_catalog = get_iceberg_catalog();
+ let iceberg_catalog = get_iceberg_catalog().await;
let namespace = NamespaceIdent::new("test_insert_nested".to_string());
set_test_namespace(&iceberg_catalog, &namespace).await?;
let table_name = "nested_table";
