This is an automated email from the ASF dual-hosted git repository.
liurenjie1024 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
The following commit(s) were added to refs/heads/main by this push:
new c6dc48fc0 infra: no need to manually install crates in CI (#1654)
c6dc48fc0 is described below
commit c6dc48fc03220541fb6032101c296fbd69644050
Author: Kevin Liu <[email protected]>
AuthorDate: Sun Sep 7 20:37:06 2025 -0700
infra: no need to manually install crates in CI (#1654)
## Which issue does this PR close?
- Closes #.
## What changes are included in this PR?
`make check-toml` and `make cargo-machete` already ensures the crates
are installed.
https://github.com/apache/iceberg-rust/blob/7362bbdcf72910d95ee88940f229d2eea40b3fa1/Makefile#L35-L42
https://github.com/apache/iceberg-rust/blob/7362bbdcf72910d95ee88940f229d2eea40b3fa1/Makefile#L29-L33
Resolves CI errror from `Check toml format`:
```
Run make check-toml
cargo install [email protected]
Updating crates.io index
Downloading crates ...
Downloaded taplo-cli v0.9.3
error: binary `taplo` already exists in destination
Add --force to overwrite
make: *** [install-taplo-cli] Error 101
Error: Process completed with exit code 2.
```
## Are these changes tested?
---
.github/workflows/ci.yml | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8f2e1dfda..9546109ee 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -49,10 +49,6 @@ jobs:
- name: Check License Header
uses: apache/skywalking-eyes/[email protected]
- - name: Install taplo-cli
- uses: taiki-e/install-action@v2
- with:
- tool: [email protected]
- name: Check toml format
run: make check-toml
@@ -65,12 +61,8 @@ jobs:
- name: Cargo clippy
run: make check-clippy
- - name: Install cargo-machete
- uses: taiki-e/install-action@v2
- with:
- tool: cargo-machete
- name: Cargo Machete
- run: cargo machete
+ run: make cargo-machete
build:
runs-on: ${{ matrix.os }}
