This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-cpp.git


The following commit(s) were added to refs/heads/main by this push:
     new 8b6118c  fix: disable CRoaring tests and microbenchmarks (#241)
8b6118c is described below

commit 8b6118c999368da2e9f399cdee258cf2d3b47efe
Author: Junwang Zhao <zhjw...@gmail.com>
AuthorDate: Mon Sep 22 02:20:44 2025 +0800

    fix: disable CRoaring tests and microbenchmarks (#241)
    
    Previously, we mistakenly used the outdated option BUILD_TESTING for
    CRoaring, change it to ENABLE_ROARING_TESTS, and also disable
    ENABLE_ROARING_MICROBENCHMARKS.
---
 cmake_modules/IcebergThirdpartyToolchain.cmake | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cmake_modules/IcebergThirdpartyToolchain.cmake 
b/cmake_modules/IcebergThirdpartyToolchain.cmake
index df3b989..3f3abf5 100644
--- a/cmake_modules/IcebergThirdpartyToolchain.cmake
+++ b/cmake_modules/IcebergThirdpartyToolchain.cmake
@@ -267,9 +267,8 @@ endfunction()
 function(resolve_croaring_dependency)
   prepare_fetchcontent()
 
-  set(BUILD_TESTING
-      OFF
-      CACHE BOOL "Disable CRoaring tests" FORCE)
+  set(ENABLE_ROARING_TESTS OFF)
+  set(ENABLE_ROARING_MICROBENCHMARKS OFF)
 
   fetchcontent_declare(croaring
                        ${FC_DECLARE_COMMON_OPTIONS}

Reply via email to