This is an automated email from the ASF dual-hosted git repository.
liurenjie1024 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
The following commit(s) were added to refs/heads/main by this push:
new f10c0ab0e ci: Don't dismiss stale review to make contribution easier
(#1799)
f10c0ab0e is described below
commit f10c0ab0e4b30c44679614231e1f299a20205697
Author: Xuanwo <[email protected]>
AuthorDate: Wed Oct 29 11:05:05 2025 +0800
ci: Don't dismiss stale review to make contribution easier (#1799)
## Which issue does this PR close?
- Closes #.
## What changes are included in this PR?
I made this change to avoid dismissing stale reviews to make
contributions easier.
iceberg is quite active, and we nearly have conflicts every day. It can
be a pain for contributors to get approved, especially after resolving
conflicts—they then have to wait for reviewers to give another approval.
I think we can make it clear that trivial changes like resolving merge
conflicts are allowed, but adding other code changes aren't. We can just
add this to the docs so it’s easier for everyone.
## Are these changes tested?
---
.asf.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.asf.yaml b/.asf.yaml
index 1a766f533..842ffc39a 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -40,7 +40,7 @@ github:
required_pull_request_reviews:
required_approving_review_count: 1
- dismiss_stale_reviews: true
+ dismiss_stale_reviews: false
required_linear_history: true
del_branch_on_merge: true
