This is an automated email from the ASF dual-hosted git repository.

huaxingao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 65c667da2f Nit: Move unchecked suppression down to violating 
assignment in `ParquetMetricsRowGroupFilter` (#14013)
65c667da2f is described below

commit 65c667da2f7231bdfa571864e0436868bfbd4918
Author: Sreesh Maheshwar <[email protected]>
AuthorDate: Sun Nov 30 08:04:45 2025 +0000

    Nit: Move unchecked suppression down to violating assignment in 
`ParquetMetricsRowGroupFilter` (#14013)
    
    Co-authored-by: Sreesh Maheshwar <[email protected]>
---
 .../java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
 
b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
index 89ded2a8ac..cae9447513 100644
--- 
a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
+++ 
b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
@@ -438,7 +438,6 @@ public class ParquetMetricsRowGroupFilter {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
       int id = ref.fieldId();
 
@@ -448,6 +447,7 @@ public class ParquetMetricsRowGroupFilter {
         return ROWS_CANNOT_MATCH;
       }
 
+      @SuppressWarnings("unchecked")
       Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
       if (colStats != null && !colStats.isEmpty()) {
         if (allNulls(colStats, valueCount)) {
@@ -487,7 +487,6 @@ public class ParquetMetricsRowGroupFilter {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
       int id = ref.fieldId();
       Long valueCount = valueCounts.get(id);
@@ -497,6 +496,7 @@ public class ParquetMetricsRowGroupFilter {
         return ROWS_MIGHT_MATCH;
       }
 
+      @SuppressWarnings("unchecked")
       Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
       if (colStats != null && !colStats.isEmpty()) {
         if (mayContainNull(colStats)) {

Reply via email to