This is an automated email from the ASF dual-hosted git repository.

huaxingao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new a7b8a08b2a Spark 4.1: Fix spark 4.1 test for unlink table metadata's 
last-updated timestamp (#15004)
a7b8a08b2a is described below

commit a7b8a08b2abb6125ffbe6ea61817e5826db61ab2
Author: Hongyue/Steve Zhang <[email protected]>
AuthorDate: Thu Jan 8 17:17:17 2026 -0800

    Spark 4.1: Fix spark 4.1 test for unlink table metadata's last-updated 
timestamp (#15004)
---
 .../java/org/apache/iceberg/spark/extensions/TestMetadataTables.java | 5 ++---
 .../org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java | 5 +++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
 
b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
index 6082c5a4e4..6e608f8c43 100644
--- 
a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
+++ 
b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
@@ -579,7 +579,7 @@ public class TestMetadataTables extends ExtensionsTestBase {
                 parentSnapshot.schemaId(),
                 parentSnapshot.sequenceNumber()),
             row(
-                
DateTimeUtils.toJavaTimestamp(currentSnapshot.timestampMillis() * 1000),
+                
DateTimeUtils.toJavaTimestamp(tableMetadata.lastUpdatedMillis() * 1000),
                 tableMetadata.metadataFileLocation(),
                 currentSnapshot.snapshotId(),
                 currentSnapshot.schemaId(),
@@ -598,8 +598,7 @@ public class TestMetadataTables extends ExtensionsTestBase {
         "Result should match the latest snapshot entry",
         ImmutableList.of(
             row(
-                DateTimeUtils.toJavaTimestamp(
-                    tableMetadata.currentSnapshot().timestampMillis() * 1000),
+                
DateTimeUtils.toJavaTimestamp(tableMetadata.lastUpdatedMillis() * 1000),
                 tableMetadata.metadataFileLocation(),
                 tableMetadata.currentSnapshot().snapshotId(),
                 tableMetadata.currentSnapshot().schemaId(),
diff --git 
a/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
 
b/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
index 63994726ca..67647925e5 100644
--- 
a/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
+++ 
b/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
@@ -46,6 +46,7 @@ import org.apache.avro.generic.GenericRecordBuilder;
 import org.apache.iceberg.DataFile;
 import org.apache.iceberg.DeleteFile;
 import org.apache.iceberg.Files;
+import org.apache.iceberg.HasTableOperations;
 import org.apache.iceberg.ManifestFile;
 import org.apache.iceberg.PartitionSpec;
 import org.apache.iceberg.Schema;
@@ -821,6 +822,10 @@ public abstract class TestIcebergSourceTablesBase extends 
TestBase {
     // rollback the table state to the first snapshot
     table.manageSnapshots().rollbackTo(firstSnapshotId).commit();
     long rollbackTimestamp = 
Iterables.getLast(table.history()).timestampMillis();
+    assertThat(rollbackTimestamp)
+        .as("Rollback history timestamp should be greater than first snapshot 
timestamp")
+        .isEqualTo(((HasTableOperations) 
table).operations().current().lastUpdatedMillis())
+        .isGreaterThan(firstSnapshotTimestamp);
 
     inputDf
         .select("id", "data")

Reply via email to