This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new 2b84bf51 fix: redirect only error output from makefile command to do
not install uv if already present on system (#2742)
2b84bf51 is described below
commit 2b84bf513656f77e2abe189678f87bf7aed1e041
Author: Raúl Cumplido <[email protected]>
AuthorDate: Mon Jan 19 19:56:59 2026 +0100
fix: redirect only error output from makefile command to do not install uv
if already present on system (#2742)
Closes #2741
# Rationale for this change
`make install` is currently trying to install `uv` even when is present
locally:
```bash
$ make install
uv not found. Installing...
/home/raulcd/.local/bin/uv
^Cmake: *** [Makefile:62: install-uv] Interrupt
$ uv --version
uv 0.9.7
```
## Are these changes tested?
No, only validated locally on Debian 14 that it does not try to install:
```bash
$ PYTHON=3.12 make install
/home/raulcd/.local/bin/uv
uv is already installed.
uv venv --python 3.12
Using CPython 3.12.12
Creating virtual environment at: .venv
```
And validated in a clean docker container that if `uv` is not present it
installs it:
```bash
root@9e4870fda91e:/app/iceberg-python# make install
uv not found. Installing...
downloading uv 0.9.8 x86_64-unknown-linux-gnu
no checksums to verify
installing to /root/.local/bin
```
## Are there any user-facing changes?
No
---------
Co-authored-by: Kevin Liu <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 22574c5e..910e9d91 100644
--- a/Makefile
+++ b/Makefile
@@ -59,7 +59,7 @@ help: ## Display this help message
##@ Setup
install-uv: ## Ensure uv is installed
- @if ! command -v uv &> /dev/null; then \
+ @if ! command -v uv > /dev/null 2>&1; then \
echo "uv not found. Installing..."; \
curl -LsSf https://astral.sh/uv/install.sh | sh; \
else \
