This is an automated email from the ASF dual-hosted git repository.

kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new ec93fe2313 Flink: Fix test assumption which can produce flakiness  
(#15147)
ec93fe2313 is described below

commit ec93fe2313c116276acc1deff2abb47cc6e365e7
Author: Maximilian Michels <[email protected]>
AuthorDate: Tue Jan 27 02:52:41 2026 +0100

    Flink: Fix test assumption which can produce flakiness  (#15147)
    
    * Flink: Fix test assumption which can produce flakiness
    
    See https://github.com/apache/iceberg/issues/15139
    
    Under high load due to limited CI resources and parallel test execution, the
    test pipeline can run multiple Flink checkpoints before all records have 
been
    processed. This produces a slightly different but not semantically wrong 
outcome.
    
    The important part of the test is to ensure comitting once per checkpoint 
which
    is asserted further below.
    
    This closes #15139.
    
    * Port to other Flink versions
---
 .../org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java  | 3 +--
 .../org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java  | 3 +--
 .../org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java  | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
 
b/flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
index fddd362677..dc05d0f327 100644
--- 
a/flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
+++ 
b/flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
@@ -1004,8 +1004,7 @@ class TestDynamicIcebergSink extends 
TestFlinkIcebergSinkBase {
     assertThat(lastSnapshot.summary())
         .containsAllEntriesOf(
             ImmutableMap.<String, String>builder()
-                .put("total-equality-deletes", "1")
-                .put("total-position-deletes", "1")
+                .put("total-delete-files", "2")
                 .put("total-records", "6")
                 .build());
 
diff --git 
a/flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
 
b/flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
index fddd362677..dc05d0f327 100644
--- 
a/flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
+++ 
b/flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
@@ -1004,8 +1004,7 @@ class TestDynamicIcebergSink extends 
TestFlinkIcebergSinkBase {
     assertThat(lastSnapshot.summary())
         .containsAllEntriesOf(
             ImmutableMap.<String, String>builder()
-                .put("total-equality-deletes", "1")
-                .put("total-position-deletes", "1")
+                .put("total-delete-files", "2")
                 .put("total-records", "6")
                 .build());
 
diff --git 
a/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
 
b/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
index fddd362677..dc05d0f327 100644
--- 
a/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
+++ 
b/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
@@ -1004,8 +1004,7 @@ class TestDynamicIcebergSink extends 
TestFlinkIcebergSinkBase {
     assertThat(lastSnapshot.summary())
         .containsAllEntriesOf(
             ImmutableMap.<String, String>builder()
-                .put("total-equality-deletes", "1")
-                .put("total-position-deletes", "1")
+                .put("total-delete-files", "2")
                 .put("total-records", "6")
                 .build());
 

Reply via email to