This is an automated email from the ASF dual-hosted git repository.

huaxingao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 46f72f7a0b Core: Remove dead commented-out code in Avro ValueReaders 
(#17529)
46f72f7a0b is described below

commit 46f72f7a0b6ce7901be1db90ae708dccad2fd414
Author: Uros Bojanic <[email protected]>
AuthorDate: Wed Aug 5 23:32:35 2026 +0200

    Core: Remove dead commented-out code in Avro ValueReaders (#17529)
    
    Delete leftover commented-out manual readInt/readFixed blocks that follow 
the active readString/readBytes return statements in StringReader, Utf8Reader, 
BytesReader, and ByteBufferReader.
---
 .../main/java/org/apache/iceberg/avro/ValueReaders.java    | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/core/src/main/java/org/apache/iceberg/avro/ValueReaders.java 
b/core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
index ec46c56c72..3bfcae887b 100644
--- a/core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
+++ b/core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
@@ -532,9 +532,6 @@ public class ValueReaders {
       // use the decoder's readString(Utf8) method because it may be a 
resolving decoder
       this.reusedTempUtf8.set(decoder.readString(reusedTempUtf8.get()));
       return reusedTempUtf8.get().toString();
-      //      int length = decoder.readInt();
-      //      byte[] bytes = new byte[length];
-      //      decoder.readFixed(bytes, 0, length);
     }
 
     @Override
@@ -556,9 +553,6 @@ public class ValueReaders {
       } else {
         return decoder.readString(null);
       }
-      //      int length = decoder.readInt();
-      //      byte[] bytes = new byte[length];
-      //      decoder.readFixed(bytes, 0, length);
     }
 
     @Override
@@ -669,10 +663,6 @@ public class ValueReaders {
       // a new buffer. since the usual case requires an allocation anyway to 
get the size right,
       // just allocate every time.
       return decoder.readBytes(null).array();
-      //      int length = decoder.readInt();
-      //      byte[] bytes = new byte[length];
-      //      decoder.readFixed(bytes, 0, length);
-      //      return bytes;
     }
 
     @Override
@@ -694,10 +684,6 @@ public class ValueReaders {
       } else {
         return decoder.readBytes(null);
       }
-      //      int length = decoder.readInt();
-      //      byte[] bytes = new byte[length];
-      //      decoder.readFixed(bytes, 0, length);
-      //      return bytes;
     }
 
     @Override

Reply via email to