hubcio commented on code in PR #1624:
URL: https://github.com/apache/iggy/pull/1624#discussion_r1987122119
##########
sdk/src/error.rs:
##########
@@ -232,6 +232,8 @@ pub enum IggyError {
CannotReadTopics(u32) = 2017,
#[error("Invalid replication factor")]
InvalidReplicationFactor = 2018,
+ #[error("Too many segments")]
Review Comment:
please include the limit, e.g. make the error msg a bit more descriptive
##########
sdk/src/segments/delete_segments.rs:
##########
@@ -0,0 +1,182 @@
+use crate::bytes_serializable::BytesSerializable;
+use crate::command::{Command, DELETE_SEGMENTS_CODE};
+use crate::error::IggyError;
+use crate::identifier::Identifier;
+use crate::utils::sizeable::Sizeable;
+use crate::validatable::Validatable;
+use bytes::{BufMut, Bytes, BytesMut};
+use serde::{Deserialize, Serialize};
+use std::fmt::Display;
+
+use super::MAX_SEGMENTS_COUNT;
Review Comment:
`MAX_SEGMENTS_COUNT` suggest that it is maximum segments count, while in
reality it is maximum number of segments that can be deleted at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
