spetz commented on PR #1872: URL: https://github.com/apache/iggy/pull/1872#issuecomment-2979540677
Hey, Thank you for the contribution! Please check how the example connectors are implemented, by making use of either `Sink` or `Source` trait (exposing the basic functions), which can be then easily loaded by the runtime. The tutorial can be found under `sinks` / `source` readme files, as well as here [iggy.apache.org/docs/connectors/sink](https://iggy.apache.org/docs/connectors/sink). I think that your code can be refactored to support the desired plugin system. Speaking of the configuration, as well as the basic overview of the connector capabilities, you could add the separate `README.md` files under e.g. `/sinks/elastic_search_sink` and `/sources/elastic_search_source` modules (we can also copy the docs to Apache Website). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@iggy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
