numinnex commented on code in PR #1900:
URL: https://github.com/apache/iggy/pull/1900#discussion_r2160319719


##########
core/integration/tests/server/tcp_server.rs:
##########
@@ -168,15 +168,31 @@ async fn should_delete_segments_via_tcp_binary_protocol() 
{
 
 #[tokio::test]
 #[parallel]
-async fn should_verify_data_integrity_after_server_restart() {
+async fn 
should_verify_data_integrity_after_server_restart_with_open_segment_index_cache()
 {
+    
verify_data_integrity_after_server_restart_with_cache_setting("open_segment").await;
+}
+
+#[tokio::test]
+#[parallel]
+async fn 
should_verify_data_integrity_after_server_restart_with_all_index_cache() {
+    verify_data_integrity_after_server_restart_with_cache_setting("all").await;
+}
+
+#[tokio::test]
+#[parallel]
+async fn 
should_verify_data_integrity_after_server_restart_with_no_index_cache() {
+    
verify_data_integrity_after_server_restart_with_cache_setting("none").await;
+}
+
+async fn 
verify_data_integrity_after_server_restart_with_cache_setting(cache_setting: 
&str) {

Review Comment:
   Change this paramenter from &str to String



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to