marvin-hansen commented on issue #1873: URL: https://github.com/apache/iggy/issues/1873#issuecomment-2998241364
In a nutshell, I suggest some wrapper like get_tcp_client() that dispatches to get_raw_client<TcpClient>() If you have any questions, just ask. Best On Tue, Jun 24, 2025 at 01:04 I-Hsin Cheng ***@***.***> wrote: > *vax-r* left a comment (apache/iggy#1873) > <https://github.com/apache/iggy/issues/1873#issuecomment-2997223695> > > How about some usage in test cases, e.g. /core/tools/src/data-seeder#L66 > <https://github.com/apache/iggy/blob/3f69440a7e8b62667ccb0820086c91364f263131/core/tools/src/data-seeder/main.rs#L66> > and /core/tools/src/data-seeder#L67 > <https://github.com/apache/iggy/blob/3f69440a7e8b62667ccb0820086c91364f263131/core/tools/src/data-seeder/main.rs#L67> > ? > > get_raw_client() now becomes get_raw_client<T>() , we need to specify the > type of client ( either TcpClient, QuicClient, HttpClient ) explicitly. > > How would you like this part to be refactored ? guess the test should be > rewrite ? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iggy/issues/1873#issuecomment-2997223695>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFYR7XFOES774ERE3BBINOD3FAXQBAVCNFSM6AAAAAB7O4L4SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJXGIZDGNRZGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
