haze518 commented on code in PR #1904:
URL: https://github.com/apache/iggy/pull/1904#discussion_r2164186066
##########
foreign/go/benchmarks/send_messages_benchmark_test.go:
##########
@@ -148,7 +148,11 @@ func CreateMessages(messagesCount, messageSize int)
[]iggcon.IggyMessage {
}
id, _ := uuid.NewUUID()
- messages[i] = iggcon.NewIggyMessage(id, payload)
+ var err error
Review Comment:
It's probably just a matter of taste. I just don't really like that the
variable gets re-declared on every iteration of the loop, but yeah, it doesn't
affect performance. Let's keep it as it is :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
