chengxilo commented on code in PR #1916: URL: https://github.com/apache/iggy/pull/1916#discussion_r2173387923
########## foreign/go/iggycli/iggy_client.go: ########## @@ -0,0 +1,193 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package iggycli + +import ( + . "github.com/apache/iggy/foreign/go/contracts" + ierror "github.com/apache/iggy/foreign/go/errors" +) + +type IggyClient struct { Review Comment: Oh for this part, actually I was creating the builder according to rust source code. In the rust source code we have IggyClient to wrap the tcp/quic/http client. https://github.com/apache/iggy/blob/934cf1c36435535cb12470fef381e3a5af824ad3/core/sdk/src/clients/client.rs#L47-L51 So I want to use the similar structure to make it more convinient to add encryptor and partitioner in the future. Maybe I need to add some comment to this part to show that I keep this wrapper intentionally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
