sobczal2 commented on code in PR #2178:
URL: https://github.com/apache/iggy/pull/2178#discussion_r2362576248
##########
.github/actions/csharp-dotnet/pre-merge/action.yml:
##########
@@ -47,36 +47,34 @@ runs:
- name: Restore dependencies
run: |
- cd foreign/csharp
- dotnet restore
+ dotnet restore foreign/csharp/Iggy_SDK.sln
+ dotnet restore examples/csharp/Iggy_SDK.Examples.sln
shell: bash
- name: Build
run: |
- cd foreign/csharp
- dotnet build --no-restore
+ dotnet build foreign/csharp/Iggy_SDK.sln --no-restore
+ dotnet build examples/csharp/Iggy_SDK.Examples.sln --no-restore
shell: bash
- name: Lint (Code Analysis)
if: inputs.task == 'lint'
run: |
- cd foreign/csharp
-
# Run code analysis
- dotnet build --no-restore /p:EnforceCodeStyleInBuild=true
/p:TreatWarningsAsErrors=false
+ dotnet build foreign/csharp/Iggy_SDK.sln --no-restore
/p:EnforceCodeStyleInBuild=true /p:TreatWarningsAsErrors=false
+ dotnet build examples/csharp/Iggy_SDK.Examples.sln --no-restore
/p:EnforceCodeStyleInBuild=true /p:TreatWarningsAsErrors=false
# TODO: make format check blocking (requires dotnet-format tool)
Review Comment:
This will invoke plenty of changes in the SDK itself. @lukaszzborek
mentioned that he is working on a task there right now, it will be very
difficult to merge, maybe we can fix it after that one? I can't even remove it
just for examples, because examples sln references Iggy_SDK csproj, so dotnet
format also checks it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
