mmodzelewski commented on code in PR #2300: URL: https://github.com/apache/iggy/pull/2300#discussion_r2491002661
########## foreign/java/external-processors/iggy-connector-flink/iggy-connector-library/src/main/java/org/apache/iggy/connector/flink/sink/IggySinkWriter.java: ########## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iggy.connector.flink.sink; + +import org.apache.flink.api.connector.sink2.SinkWriter; +import org.apache.iggy.client.blocking.http.IggyHttpClient; +import org.apache.iggy.identifier.StreamId; +import org.apache.iggy.identifier.TopicId; +import org.apache.iggy.message.Message; +import org.apache.iggy.message.MessageHeader; +import org.apache.iggy.message.MessageId; +import org.apache.iggy.message.Partitioning; +import org.apache.iggy.connector.error.ConnectorException; +import org.apache.iggy.connector.serialization.SerializationSchema; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.math.BigInteger; +import java.time.Duration; +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.zip.CRC32; +import java.util.zip.Checksum; + +/** + * Sink writer implementation for writing records to Iggy. + * Buffers records and flushes them in batches for efficiency. + */ +public class IggySinkWriter<T> implements SinkWriter<T> { + + private static final Logger LOGGER = LoggerFactory.getLogger(IggySinkWriter.class); + + private final IggyHttpClient httpClient; + private final String streamId; + private final String topicId; + private final SerializationSchema<T> serializer; + private final int batchSize; + private final Duration flushInterval; + private final PartitioningStrategy partitioningStrategy; + + private final List<T> buffer; + private long lastFlushTime; + private long totalWritten; + + /** + * Strategy for determining partition assignment. + */ + public enum PartitioningStrategy { + BALANCED, + PARTITION_ID, + MESSAGE_KEY + } + + /** + * Creates a new sink writer. + * + * @param httpClient the HTTP Iggy client + * @param streamId the stream identifier + * @param topicId the topic identifier + * @param serializer the serialization schema + * @param batchSize maximum number of records to buffer before flushing + * @param flushInterval maximum time to wait before flushing + * @param partitioningStrategy the partitioning strategy + */ + public IggySinkWriter( + IggyHttpClient httpClient, + String streamId, + String topicId, + SerializationSchema<T> serializer, + int batchSize, + Duration flushInterval, + PartitioningStrategy partitioningStrategy) { + + if (httpClient == null) { + throw new IllegalArgumentException("httpClient cannot be null"); + } + if (streamId == null || streamId.isEmpty()) { + throw new IllegalArgumentException("streamId cannot be null or empty"); + } + if (topicId == null || topicId.isEmpty()) { + throw new IllegalArgumentException("topicId cannot be null or empty"); + } + if (serializer == null) { + throw new IllegalArgumentException("serializer cannot be null"); + } + if (batchSize <= 0) { + throw new IllegalArgumentException("batchSize must be > 0"); + } + if (flushInterval == null || flushInterval.isNegative()) { + throw new IllegalArgumentException("flushInterval must be positive"); + } + + this.httpClient = httpClient; + this.streamId = streamId; + this.topicId = topicId; + this.serializer = serializer; + this.batchSize = batchSize; + this.flushInterval = flushInterval; + this.partitioningStrategy = partitioningStrategy != null + ? partitioningStrategy + : PartitioningStrategy.BALANCED; + + this.buffer = new ArrayList<>(batchSize); + this.lastFlushTime = System.currentTimeMillis(); + this.totalWritten = 0; + } + + @Override + public void write(T element, Context context) throws IOException { + LOGGER.info("IggySinkWriter.write() called - element: {}, buffer size: {}", + element, buffer.size()); + buffer.add(element); + + // Flush if batch size reached or flush interval exceeded + if (buffer.size() >= batchSize || shouldFlushByTime()) { + LOGGER.info("IggySinkWriter: Flushing buffer of size {}", buffer.size()); + flush(false); + } + } + + @Override + public void flush(boolean endOfInput) throws IOException { + if (buffer.isEmpty()) { + LOGGER.debug("IggySinkWriter.flush() - buffer is empty, skipping"); + return; + } + + LOGGER.info("IggySinkWriter.flush() - flushing {} messages to stream={}, topic={}", + buffer.size(), streamId, topicId); + + try { + // Serialize all buffered records + List<Message> messages = new ArrayList<>(buffer.size()); + for (T element : buffer) { + byte[] payload = serializer.serialize(element); + // Use createMessage to avoid String conversion + messages.add(createMessage(payload)); + } + + // Determine partitioning + Partitioning partitioning = determinePartitioning(); + + // Send messages to Iggy (HTTP with async wrapper) + StreamId stream = parseStreamId(streamId); + TopicId topic = parseTopicId(topicId); Review Comment: these ids could be parsed and assigned once in a constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
