spetz commented on code in PR #2348:
URL: https://github.com/apache/iggy/pull/2348#discussion_r2535067601
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -110,9 +164,46 @@ pub struct StreamProducerConfig {
pub linger_time: Option<String>,
}
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct ConnectorConfigVersionInfo {
+ pub version: u64,
+ pub is_active: bool,
+}
+
+#[derive(Debug, Default, Clone, Serialize, Deserialize)]
+pub struct ConnectorConfigVersions {
+ pub sinks: HashMap<String, Vec<ConnectorConfigVersionInfo>>,
Review Comment:
I was wondering, whether it should return all existing versions, or just the
active ones?
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -110,9 +164,46 @@ pub struct StreamProducerConfig {
pub linger_time: Option<String>,
}
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct ConnectorConfigVersionInfo {
+ pub version: u64,
+ pub is_active: bool,
+}
Review Comment:
Maybe let's also include some sort of timestamp/created_at field - for the
file config provider, this could be taken from the file metadata itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
