cstruct commented on PR #2169: URL: https://github.com/apache/iggy/pull/2169#issuecomment-3547047894
Sorry for dropping the ball here. I've had reduced bandwidth and I apologize for not communicating that I've had to put this on hold. I'm going to need this for work in a bit so I will prioritize this soon. What's next for this PR is that we have to think about the interface we want to expose. Adding this as `read_messages` and keeping the old callback based impl `consume_messages` is confusing without clearly documenting how they differ and when to use one of them. As it stands the only difference besides interface is that `consume_messages` supports `AutoCommit::After(...)`, but I don't know if that justifies having two interfaces. As far as I can remember `AutoCommit::After(...)` [still commits when the consumer yields an error](https://github.com/apache/iggy/blob/master/core/sdk/src/consumer_ext/consumer_message_ext.rs#L92-L94), so this only really guards us against committing before a `panic` in Rust? I'll try to get into this ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
