mmodzelewski commented on code in PR #2437:
URL: https://github.com/apache/iggy/pull/2437#discussion_r2584569780
##########
core/connectors/runtime/config.toml:
##########
@@ -51,3 +51,16 @@ path = "local_state"
[connectors]
config_type = "local"
config_dir = ""
+
+
+### HTTP config type example
Review Comment:
please move this part into runtime's readme file, there's an http provider
section where you can include this
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -231,6 +231,7 @@ pub async fn create_connectors_config_provider(
) -> Result<Box<dyn ConnectorsConfigProvider>, RuntimeError> {
match config {
RuntimeConnectorsConfig::Local(config) => {
+ tracing::info!("Connector Config: {:?}", config);
Review Comment:
Maybe use a debug level here. The config dir is already logged during
provider init
##########
core/integration/tests/connectors/http_config_provider/config_direct.toml:
##########
@@ -18,3 +18,10 @@
[connectors]
config_type = "http"
base_url = "http://localhost:8080";
+
+[connectors.retry]
Review Comment:
as this is already default, I think you can skip it from here and
`config_wrapped.toml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
