hubcio commented on PR #2476: URL: https://github.com/apache/iggy/pull/2476#issuecomment-3655305346
> > overall, design in this PR is sound, however i'd like you to consider: all 50+ handlers now return HandlerResult but only SendMessages use Migrated. have you thought about adding IggyError::ConnectionMigrated(to_shard) and catch it in connection handler? this would greatly reduce changed files in the PR > > @spetz @numinnex opinions? > > I actually did that in the first place, but on second thought, this is not an error, so I have to change all of the handler results. I would be happy to change it if you prefer to treat it as an error I mean your approach does make sense... Lets wait for other core devs opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
