hubert-laserdata commented on code in PR #2504:
URL: https://github.com/apache/iggy/pull/2504#discussion_r2634579013
##########
.github/workflows/_test_examples.yml:
##########
@@ -72,6 +72,18 @@ jobs:
path: ~/.cache/pip
key: pip-${{ runner.os }}-${{
hashFiles('foreign/python/pyproject.toml') }}
+ - name: Setup Java
+ uses: actions/setup-java@v4
+ with:
+ distribution: "temurin"
+ java-version: "17"
+ cache: "gradle"
+
+ - name: Setup Gradle
+ uses:
gradle/actions/setup-gradle@af1da67850ed9a4cedd57bfd976089dd991e2582 # v4.0.0
+ with:
+ gradle-version: "9.2.1"
+
Review Comment:
both of these steps should be executed only under condition `if:
inputs.component == 'examples-suite' && inputs.task == 'examples-java'`
##########
.github/workflows/_test_examples.yml:
##########
@@ -72,6 +72,18 @@ jobs:
path: ~/.cache/pip
key: pip-${{ runner.os }}-${{
hashFiles('foreign/python/pyproject.toml') }}
+ - name: Setup Java
+ uses: actions/setup-java@v4
+ with:
+ distribution: "temurin"
+ java-version: "17"
+ cache: "gradle"
+
+ - name: Setup Gradle
+ uses:
gradle/actions/setup-gradle@af1da67850ed9a4cedd57bfd976089dd991e2582 # v4.0.0
+ with:
+ gradle-version: "9.2.1"
+
Review Comment:
both of these steps should be executed only under condition `if:
inputs.component == 'examples-suite' && inputs.task == 'examples-java'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
