hubcio commented on PR #2418: URL: https://github.com/apache/iggy/pull/2418#issuecomment-3705073325
By not properly integrated I mean: - `slice_by_timestamp()` still uses `binary_search_position_for_timestamp_sync()` - `find_by_timestamp_block_aware()` is not used in production code - `round_up_to_cache_line()` is used only in test code also: - `IndexCacheLineBlock` is in wrong location, this is server-side optimization, should be somewhere in `core/server/src/streaming/segments/indexes` - benchmark files like `indexes_mut_bench.rs` should be inside `integration` package, also I suggest to convert them to use `criterion` Lastly, I remember that we were talking that you'll present some measurable gains. Can you comment on that? Did this change yield any measurable performance improvement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
