hubcio commented on code in PR #2520:
URL: https://github.com/apache/iggy/pull/2520#discussion_r2657524994
##########
.github/config/components.yml:
##########
@@ -275,7 +279,8 @@ components:
web-ui:
paths:
- "web/**"
- tasks: ["lint", "build"]
+ - "core/server/**"
Review Comment:
remove this line and add `depends-on: rust-server`
##########
.github/config/components.yml:
##########
@@ -59,6 +59,10 @@ components:
- "rust-binary-protocol"
paths:
- "core/server/**"
+ # if we only detect changes to the Web UI end-to-end test suite,
+ # do not trigger all the workflows: it is "web-ui" component and
+ # its dedicated task that got e2e tests execution covered
+ - "!core/server/tests/e2e-web/**"
Review Comment:
I disagree. By changing iggy-server, you can change the binary protocol
(contract or API), which can break the frontend tests you wrote, and we plan to
catch it in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
