ex172000 commented on code in PR #2560:
URL: https://github.com/apache/iggy/pull/2560#discussion_r2693105910
##########
foreign/java/external-processors/iggy-connector-flink/iggy-connector-library/README.md:
##########
@@ -6,6 +6,43 @@ Core connector library for integrating Apache Iggy with stream
processing engine
This library provides framework-agnostic abstractions and Flink-specific
implementations for reading from and writing to Iggy streams.
+### Transport Protocols
+
+The connector supports two transport protocols for communicating with the Iggy
server:
+
+| Transport | Default Port | Use Case
|
+| -------------------- | ------------ |
------------------------------------------------------------ |
+| **HTTP** (default) | 3000 | Development, debugging, environments
with HTTP proxies |
Review Comment:
Not sure if we should ask users to leverage production settings as much as
possible? Thus making TCP the default makes more sense?
##########
foreign/java/external-processors/iggy-connector-flink/iggy-connector-library/src/main/java/org/apache/iggy/connector/config/IggyConnectionConfig.java:
##########
@@ -86,6 +116,42 @@ public String getServerAddress() {
return serverAddress;
}
+ /**
+ * Gets the transport type (HTTP or TCP).
+ *
+ * @return the transport type
+ */
+ public TransportType getTransportType() {
+ return transportType;
+ }
+
+ /**
+ * Gets the HTTP API port.
+ *
+ * @return the HTTP port (default 3000)
+ */
+ public int getHttpPort() {
+ return httpPort;
+ }
+
+ /**
+ * Gets the TCP API port.
+ *
+ * @return the TCP port (default 8090)
+ */
+ public int getTcpPort() {
+ return tcpPort;
+ }
+
+ /**
+ * Gets the effective port based on the configured transport type.
+ *
+ * @return the port for the current transport type
+ */
+ public int getEffectivePort() {
Review Comment:
I don't see it's used anywhere except the test, can we remove it or restrict
its access to tests only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
