hubcio opened a new issue, #2592:
URL: https://github.com/apache/iggy/issues/2592

   Currently the Elasticsearch sink connector has no integration tests. The 
Postgres connector (see #2579) is a good reference for the testing approach we 
want.
   
   ## What needs testing
   
   - Basic indexing flow: send messages to Iggy → verify documents land in 
Elasticsearch
   - JSON payload handling (the connector does JSON parsing)
   - Bytea/raw payload handling
   - Bulk indexing behavior
   - Authentication (username/password credentials)
   
   ## Implementation notes
   
   - Spin up Elasticsearch via testcontainers
   - Use the same `ConnectorsRuntime` setup from 
`core/integration/tests/connectors/`
   - Follow the postgres tests pattern: setup helpers, assertion helpers, clear 
test naming
   
   ## Files to reference
   
   - `core/integration/tests/connectors/postgres/postgres_sink.rs` - test 
structure
   - `core/connectors/sinks/elasticsearch_sink/src/lib.rs` - sink implementation
   
   ## Acceptance criteria
   
   - [ ] At least 2-3 tests covering different payload types
   - [ ] Tests run in CI (may need ES container in docker-compose)
   - [ ] Test failures are informative
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to