This is an automated email from the ASF dual-hosted git repository.
hgruszecki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/master by this push:
new 0316511b7 fix(web): remove logout side-effect from page load (#2597)
0316511b7 is described below
commit 0316511b7fbb7b3ef3ce331dc57415d6154e143c
Author: JoshuaXOng <[email protected]>
AuthorDate: Wed Jan 21 17:54:04 2026 +1100
fix(web): remove logout side-effect from page load (#2597)
---
web/package-lock.json | 18 +++++++++++-------
web/src/routes/auth/logout/+page.ts | 34 ----------------------------------
2 files changed, 11 insertions(+), 41 deletions(-)
diff --git a/web/package-lock.json b/web/package-lock.json
index d7876bcb5..51c67f4fc 100644
--- a/web/package-lock.json
+++ b/web/package-lock.json
@@ -1457,9 +1457,9 @@
}
},
"node_modules/@sveltejs/kit": {
- "version": "2.49.0",
- "resolved": "https://registry.npmjs.org/@sveltejs/kit/-/kit-2.49.0.tgz";,
- "integrity":
"sha512-oH8tXw7EZnie8FdOWYrF7Yn4IKrqTFHhXvl8YxXxbKwTMcD/5NNCryUSEXRk2ZR4ojnub0P8rNrsVGHXWqIDtA==",
+ "version": "2.50.0",
+ "resolved": "https://registry.npmjs.org/@sveltejs/kit/-/kit-2.50.0.tgz";,
+ "integrity":
"sha512-Hj8sR8O27p2zshFEIJzsvfhLzxga/hWw6tRLnBjMYw70m1aS9BSYCqAUtzDBjRREtX1EvLMYgaC0mYE3Hz4KWA==",
"dev": true,
"license": "MIT",
"dependencies": {
@@ -1468,7 +1468,7 @@
"@types/cookie": "^0.6.0",
"acorn": "^8.14.1",
"cookie": "^0.6.0",
- "devalue": "^5.3.2",
+ "devalue": "^5.6.2",
"esm-env": "^1.2.2",
"kleur": "^4.1.5",
"magic-string": "^0.30.5",
@@ -1487,11 +1487,15 @@
"@opentelemetry/api": "^1.0.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0 || ^4.0.0-next.1 || ^5.0.0 ||
^6.0.0-next.0",
"svelte": "^4.0.0 || ^5.0.0-next.0",
+ "typescript": "^5.3.3",
"vite": "^5.0.3 || ^6.0.0 || ^7.0.0-beta.0"
},
"peerDependenciesMeta": {
"@opentelemetry/api": {
"optional": true
+ },
+ "typescript": {
+ "optional": true
}
}
},
@@ -2684,9 +2688,9 @@
}
},
"node_modules/devalue": {
- "version": "5.5.0",
- "resolved": "https://registry.npmjs.org/devalue/-/devalue-5.5.0.tgz";,
- "integrity":
"sha512-69sM5yrHfFLJt0AZ9QqZXGCPfJ7fQjvpln3Rq5+PS03LD32Ost1Q9N+eEnaQwGRIriKkMImXD56ocjQmfjbV3w==",
+ "version": "5.6.2",
+ "resolved": "https://registry.npmjs.org/devalue/-/devalue-5.6.2.tgz";,
+ "integrity":
"sha512-nPRkjWzzDQlsejL1WVifk5rvcFi/y1onBRxjaFMjZeR9mFpqu2gmAZ9xUB9/IEanEP/vBtGeGganC/GO1fmufg==",
"dev": true,
"license": "MIT"
},
diff --git a/web/src/routes/auth/logout/+page.ts
b/web/src/routes/auth/logout/+page.ts
deleted file mode 100644
index 5de770f46..000000000
--- a/web/src/routes/auth/logout/+page.ts
+++ /dev/null
@@ -1,34 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { browser } from '$app/environment';
-import { goto } from '$app/navigation';
-import { resolve } from '$app/paths';
-import { authStore } from '$lib/auth/authStore.svelte';
-import { typedRoute } from '$lib/types/appRoutes';
-import type { PageLoad } from './$types';
-
-export const load: PageLoad = async () => {
- if (browser) {
- authStore.logout();
- goto(resolve(typedRoute('/auth/sign-in')));
- }
-
- return {};
-};
