slbotbm commented on code in PR #2601: URL: https://github.com/apache/iggy/pull/2601#discussion_r2714820073
########## PULL_REQUEST_TEMPLATE.md: ########## @@ -0,0 +1,52 @@ +## Which issue does this PR close? + +<!-- +We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. +--> + +Closes # + +## Rationale + +<!-- +Why is this change needed? If the issue explains it well, a one-liner is fine. +--> + +## What changed? + +<!-- +2-4 sentences. Problem first (before), then solution (after). + +GOOD: + +"Messages were unavailable when background message_saver committed the +journal and started async disk I/O before completion. Polling during +this window found neither journal nor disk data. + +The fix freezes journal batches in the in-flight buffer before async persist." + +GOOD: + +"When many small messages accumulate in the journal, the flush passes +thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)." + +BAD: +- Walls of text +- "This PR adds..." (we can see the diff) +--> + +## Local Execution + +Not passed / passed. + +<!-- +You must run your code locally before submitting. +"Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed. +--> + +## AI Usage + +<!-- +If AI tools were used, state which (e.g., "GitHub Copilot", "Claude", "ChatGPT"). +If not, write "None" or delete this section. +--> Review Comment: I think instead of just asking "what model", it would be better to ask for the scope of usage of AI, how was the code verified, and if the contributor can explain every line of the code by themselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
