mmodzelewski commented on PR #2609:
URL: https://github.com/apache/iggy/pull/2609#issuecomment-3810808387

   > Ah, also let me know if you want me to change the commit messages of 
[c6aeb8e](https://github.com/apache/iggy/commit/c6aeb8eb58f5a32a0c202313f0e706145a68a778)
 and 
[5344c95](https://github.com/apache/iggy/commit/5344c9503821e92fd4afe0ae8a1fd8bc100e443e),
 just saw the recent change removing "[only the pull request title must conform 
to this 
format](https://github.com/apache/iggy/commit/6e3a6d132a4aa7375959b436c552c100b2002455#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055L25)".
   
   No, we don't really look at commits individually. Eventually, they get 
squashed during the merge.
   
   
   > Ah, I'll close this PR for now, error message seems like there is a logic 
error in one of the added Quickwit tests- though it does not show up in local 
tests ; - ;
   
   Please let us know if you need any support. Also, if you think the current 
connectors tests setup is incorrect, feel free to improve it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to