hubcio commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2741640669


##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
       run: |
         foreign/java/dev-support/checks/build.sh test
 
+    - name: Generate coverage report
+      if: inputs.task == 'test'
+      shell: bash
+      run: |
+        foreign/java/dev-support/checks/build.sh jacocoAggregatedReport

Review Comment:
   our CI is written in way so that if e.g. rust `iggy-server` code is changed 
(because in fact it is a non-explicit dependency), it'll also run java sdk 
tests. with current approach here it'll post a comment under a PR which does 
not touch java files
   
   suggestion: before generating coverage report (or making the bot comment in 
general) check if there are any `*.java` modified files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to