JoshuaXOng commented on issue #1846: URL: https://github.com/apache/iggy/issues/1846#issuecomment-3841775407
I started coding on this one a bit. Was looking at the FlatBuffer/ProtoBuf implementations for reference, with the `encode` methods and `Schema` conversions as [used with the Connector runtime](https://github.com/apache/iggy/blob/master/core/connectors/runtime/src/source.rs#L185), they'll either try to maintain structure else fallback to an inner style wrapper / default to any wrapper. E.g., [`encode_text_to_flatbuffer`](https://github.com/apache/iggy/blob/master/core/connectors/sdk/src/encoders/flatbuffer.rs#L240) E.g., [`encode_with_any_wrapper`](https://github.com/apache/iggy/blob/master/core/connectors/sdk/src/encoders/proto.rs#L339) I'm a bit hesitant to do the same - just not really convinced outputs of similar style conversions for Avro would be useful. Was planning on instead adding Avro support with basic decode/encode implementations, with unsupported conversions ([WIP Avro branch for reference](https://github.com/apache/iggy/compare/master...JoshuaXOng:iggy:avro-payload)) - though I can kinda see this not being too useful either. @mmodzelewski could you unassign me from this particular issue, mbmb- I don't seem to have the auth to unassign myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
