slbotbm commented on code in PR #2671:
URL: https://github.com/apache/iggy/pull/2671#discussion_r2760158992
##########
.pre-commit-config.yaml:
##########
@@ -69,6 +69,20 @@ repos:
files: ^rust-toolchain\.toml$
pass_filenames: false
+ - id: python-version-sync
+ name: python sdk version sync
+ entry: ./scripts/ci/python-version-sync.sh
+ args: ["--fix"]
+ language: system
+ files: ^foreign/python/(Cargo\.toml|pyproject\.toml)$
+ pass_filenames: false
+
+ - id: python-format
+ name: python sdk format
+ entry: ruff format
+ language: system
+ files: ^foreign/python/.*\.(py|pyi)$
Review Comment:
Instead of leaving it up to the user to download ruff, wouldn't something
like
```yaml
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.14.14
hooks:
- id: ruff-check
args: [ --select, I, --fix ]
- id: ruff-format
- files: ^foreign/python/.*\.(py|pyi)$
```
be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
