lukaszzborek commented on code in PR #2701:
URL: https://github.com/apache/iggy/pull/2701#discussion_r2784301566
##########
foreign/csharp/Iggy_SDK/IggyClient/Implementations/HttpMessageStream.cs:
##########
@@ -559,6 +534,18 @@ var response
}
}
+ /// <inheritdoc />
+ public async Task DeleteSegmentsAsync(Identifier streamId, Identifier
topicId, uint partitionId,
+ uint segmentsCount, CancellationToken token = default)
+ {
+ var response = await _httpClient.DeleteAsync(
Review Comment:
I'm thinking about it, and it seems to me that since it's not supported in
HTTP, it should throw a ‘FeatureUnavailableException’ exception.`. Now it can
be missleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
