atharvalade commented on code in PR #2710:
URL: https://github.com/apache/iggy/pull/2710#discussion_r2790683845
##########
foreign/csharp/Iggy_SDK.Tests.Integration/ConsumerGroupTests.cs:
##########
@@ -21,157 +21,183 @@
using Apache.Iggy.IggyClient;
using Apache.Iggy.Tests.Integrations.Attributes;
using Apache.Iggy.Tests.Integrations.Fixtures;
-using Apache.Iggy.Tests.Integrations.Helpers;
using Shouldly;
namespace Apache.Iggy.Tests.Integrations;
public class ConsumerGroupTests
{
- private static readonly uint GroupId = 0;
- private static readonly string GroupName = "test_consumer_group";
- private Identifier TopicId => Identifier.String(Fixture.TopicId);
+ private const uint PartitionsCount = 10;
+ private const string TopicName = "cg-topic";
+ private const string GroupName = "test_consumer_group";
- [ClassDataSource<ConsumerGroupFixture>(Shared = SharedType.PerClass)]
- public required ConsumerGroupFixture Fixture { get; init; }
+ [ClassDataSource<IggyServerFixture>(Shared = SharedType.PerAssembly)]
+ public required IggyServerFixture Fixture { get; init; }
+
+ private async Task<(IIggyClient client, string streamName)>
CreateStreamAndTopic(Protocol protocol)
+ {
+ var client = protocol == Protocol.Tcp
Review Comment:
Done. Added `CreateAuthenticatedClient`(Protocol protocol) to
`IggyServerFixture` and replaced the protocol == Protocol.Tcp ?
CreateTcpClient() : CreateHttpClient() pattern across all 11 test files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
