hubcio opened a new issue, #2730: URL: https://github.com/apache/iggy/issues/2730
Prevent storing consumer offsets beyond the partition's actual message range. Applies to both set consumer offset and set consumer group offset — both flow through `store_consumer_offset`, which resolves the `PollingConsumer` (Consumer or ConsumerGroup variant) before storing. **What to focus on:** - Validate offset before `store_consumer_offset_base` is called — that's the single entry point for both consumer and consumer group offsets - Query partition stats (messages_count) to determine max valid offset - Handle empty partitions gracefully - Add integration tests for boundary cases (both consumer and consumer group paths) Done when storing an out-of-range offset fails with a descriptive error for both consumer and consumer group offsets. **Open questions:** - Should we allow offset equal to max_offset + 1 (next message position)? Doer decides, reviewers evaluate - Should validation be optional or always enforced? Enforced -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
