atharvalade commented on PR #2785: URL: https://github.com/apache/iggy/pull/2785#issuecomment-3950267700
Nice work on the infra setup. the CI integration and Bazel config are clean. Two things to fix before merge though: the `Expiry` class in `iggy.hpp` has all its getters (`expiry_type()`, `expiry_value()`, `value()`) under `private`: unlike the other three classes, so it's completely opaque after construction (and the test can only `SUCCEED()` without asserting anything). Also, the genrule `srcs` hard-codes just `src/lib.rs` as soon as a second .`rs` file is added, Bazel won't detect changes to it and will serve stale cached builds. Swapping to `glob(["src/**/*.rs"])` should fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
