mmodzelewski commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2845616756
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm
run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm
run test:e2e
Review Comment:
It looks like both `unit` and `e2e` are outputting the results into
`lcov.info`. Won't the `e2e` results overwrite the `unit` results? Does this
tool support merging results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
