seokjin0414 commented on code in PR #2845:
URL: https://github.com/apache/iggy/pull/2845#discussion_r2873794900
##########
.github/actions/rust/pre-merge/action.yml:
##########
@@ -173,13 +173,7 @@ runs:
- name: Build aarch64-musl
if: inputs.task == 'build-aarch64-musl'
- # Exclude dashboard crates: charming's "ssr" feature pulls deno_core ->
v8,
- # which has no prebuilt binary for aarch64-unknown-linux-musl.
- # TODO: support when upstream rusty_v8 publishes aarch64-musl binaries.
- run: >-
- cargo build --locked --workspace --target aarch64-unknown-linux-musl
- --exclude iggy-bench-dashboard-server
- --exclude bench-dashboard-frontend
Review Comment:
You're right, sorry about that.
It seems the rebase went wrong and accidentally reverted your changes
##########
.github/actions/rust/pre-merge/action.yml:
##########
@@ -173,13 +173,7 @@ runs:
- name: Build aarch64-musl
if: inputs.task == 'build-aarch64-musl'
- # Exclude dashboard crates: charming's "ssr" feature pulls deno_core ->
v8,
- # which has no prebuilt binary for aarch64-unknown-linux-musl.
- # TODO: support when upstream rusty_v8 publishes aarch64-musl binaries.
- run: >-
- cargo build --locked --workspace --target aarch64-unknown-linux-musl
- --exclude iggy-bench-dashboard-server
- --exclude bench-dashboard-frontend
Review Comment:
You're right sorry about that.
It seems the rebase went wrong and accidentally reverted your changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
