hubcio commented on code in PR #2853: URL: https://github.com/apache/iggy/pull/2853#discussion_r2877397300
########## core/shard/src/router.rs: ########## @@ -0,0 +1,158 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::shards_table::ShardsTable; +use crate::{IggyShard, ShardFrame}; +use futures::FutureExt; +use iggy_common::header::{GenericHeader, Operation, PrepareHeader}; +use iggy_common::message::{Message, MessageBag}; +use iggy_common::sharding::IggyNamespace; +use journal::{Journal, JournalHandle}; +use message_bus::MessageBus; +use metadata::stm::StateMachine; + +/// Inter-shard dispatch logic. +/// +/// All messages — whether destined for a local or remote shard — are routed +/// through the channel into the target shard's message pump. This ensures +/// that every mutation on a shard is serialized through a single point (the +/// pump), preventing concurrent access from independent async tasks. +impl<B, J, S, M, T, R> IggyShard<B, J, S, M, T, R> +where + B: MessageBus, + T: ShardsTable, + R: Send, Review Comment: IMHO it's OK. shard should live forever in given thread so static lifetime fits perfectly. @numinnex any thoughts? ########## core/shard/src/router.rs: ########## @@ -0,0 +1,158 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::shards_table::ShardsTable; +use crate::{IggyShard, ShardFrame}; +use futures::FutureExt; +use iggy_common::header::{GenericHeader, Operation, PrepareHeader}; +use iggy_common::message::{Message, MessageBag}; +use iggy_common::sharding::IggyNamespace; +use journal::{Journal, JournalHandle}; +use message_bus::MessageBus; +use metadata::stm::StateMachine; + +/// Inter-shard dispatch logic. +/// +/// All messages — whether destined for a local or remote shard — are routed +/// through the channel into the target shard's message pump. This ensures +/// that every mutation on a shard is serialized through a single point (the +/// pump), preventing concurrent access from independent async tasks. +impl<B, J, S, M, T, R> IggyShard<B, J, S, M, T, R> +where + B: MessageBus, + T: ShardsTable, + R: Send, Review Comment: IMHO it's OK. shard (and messages router) should live forever in given thread so static lifetime fits perfectly. @numinnex any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
