spetz commented on code in PR #2781:
URL: https://github.com/apache/iggy/pull/2781#discussion_r2894883849
##########
core/connectors/runtime/src/manager/sink.rs:
##########
@@ -96,6 +108,163 @@ impl SinkManager {
sink.info.last_error = Some(ConnectorError::new(error_message));
}
}
+
+ pub async fn stop_connector_with_guard(
+ &self,
+ key: &str,
+ metrics: &Arc<Metrics>,
+ ) -> Result<(), RuntimeError> {
+ let guard = {
+ let details_arc = self
Review Comment:
Do we need to name this with `_arc`? Could be just `details`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
