amuldotexe commented on PR #2815: URL: https://github.com/apache/iggy/pull/2815#issuecomment-4011120821
Addressed the review feedback in `07bd2317`. What changed: - Removed the shared runtime sink callback-status change from this PR. `core/connectors/runtime/src/sink.rs` is back to connector-runtime behavior, so the MongoDB PR no longer changes sink behavior for all connectors. - Completed the remaining range-safe metadata handling in the MongoDB sink for checksum, timestamp, and origin timestamp. - Kept the sink-local fixes already on the branch: `ordered(false)` batch inserts, duplicate-key replay tolerance, composite `_id`, `AtomicU64` counters, config normalization in `new()`, and warning on unknown `payload_format`. - Re-scoped the two MongoDB integration tests that had been asserting runtime `last_error` / `ConnectorStatus::Error` semantics. They now validate connector-local MongoDB outcomes only. Validation run on this head: - `cargo clippy -p iggy_connector_mongodb_sink -p iggy-connectors --all-targets --all-features -- -D warnings` - `cargo test -p iggy-connectors` - `cargo test -p iggy_connector_mongodb_sink` - `cargo build -p server --bin iggy-server` - `cargo build -p iggy-connectors --bin iggy-connectors` - `cargo build -p iggy_connector_mongodb_sink --lib` - `cargo test -p integration --test mod connectors::mongodb::mongodb_sink::` - `cargo build --all-targets --all-features` Current PR head: `07bd2317f52b25484e91c0c697dd43d32ec4b2d9`. @krishvishal @atharvalade please take another look when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
