atharvalade commented on code in PR #2870:
URL: https://github.com/apache/iggy/pull/2870#discussion_r2898877427
##########
core/consensus/Cargo.toml:
##########
@@ -38,3 +38,8 @@ rand_xoshiro = { workspace = true }
[dev-dependencies]
futures = { workspace = true }
+
+[lints.clippy]
+enum_glob_use = "deny"
+pedantic = "deny"
+nursery = "deny"
Review Comment:
arent nursery lints explicitly unstable? clippy may rename, remove, or
introduce false positives for them between releases. With "deny", any such
upstream change becomes a hard build failure the next time the toolchain is
bumped past 1.93.0.
why dont you consider using "warn" here instead; you get the same
enforcement by failing on warnings in CI, without the risk of a toolchain
update unexpectedly breaking the consensus crate. I see `core/bench` already
does the same, so it might be worth revisiting that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
