atharvalade opened a new pull request, #2890:
URL: https://github.com/apache/iggy/pull/2890

   ## Which issue does this PR close?
   
   Closes #2225
   
   ## Rationale
   
   The async `ConsumerGroupsTcpClient` had no dedicated test coverage. While 
the blocking client had `ConsumerGroupsClientBaseTest` and 
`ConsumerGroupsTcpClientTest`, the async path only had a few scattered tests 
inside the monolithic `AsyncClientIntegrationTest`. Dedicated tests are needed 
to verify correct `CompletableFuture` semantics.
   
   ## What changed?
   
   The async consumer groups client had no focused test class, leaving 
join/leave, error propagation, and concurrent `CompletableFuture` patterns 
untested.
   
   Added `AsyncConsumerGroupsTest.java` with 17 tests covering all six API 
operations (create, get by id, get by name, list, delete by id, delete by 
name), join/leave membership including multi-client scenarios, error scenarios 
that assert `IggyResourceNotFoundException` propagates correctly through 
`ExecutionException`, and `CompletableFuture`-specific patterns such as 
`thenCompose` chaining and `allOf` concurrent operations.
   
   ## Local Execution
   
   - Passed
   - Pre-commit hooks ran
   
   ## AI Usage
   
   1. Opus 4.6
   2. Minimal usage: used for codebase exploration and initial scaffolding. All 
test logic, assertions, and cleanup patterns were reviewed and verified against 
existing test classes.
   3. Ran the full test suite locally via `./gradlew :iggy:test` confirming 
17/17 tests pass with 0 failures and no Netty resource leaks.
   4. Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to