hubcio commented on code in PR #2852:
URL: https://github.com/apache/iggy/pull/2852#discussion_r2907265353
##########
foreign/cpp/Cargo.lock:
##########
Review Comment:
don't overcomplicate it.
`Cargo.lock` should always be committed and `--locked should` stay
unconditional (both locally and in CI).
That's the standard approach for binary/cdylib crates and we already do it
for the root Cargo.lock.
the fix is on the workflow side: whenever you touch Cargo.toml, run cargo
check or cargo update -w to refresh the lockfile, then commit it together with
your changes. --locked failing on a stale lockfile is working as intended- it's
catching the
mismatch early.
No need to conditionally disable it.just keep all deps pinned to strict
versions (semver = major.minor.patch).
##########
foreign/cpp/Cargo.toml:
##########
@@ -28,6 +28,8 @@ crate-type = ["staticlib"]
[dependencies]
cxx = "1.0.194"
+iggy = { path = "../../core/sdk" }
+tokio = { version = "1", features = ["rt-multi-thread"] }
Review Comment:
use strict version of tokio - we aim to have `somewhat` reproducible builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
