hubcio commented on code in PR #2937:
URL: https://github.com/apache/iggy/pull/2937#discussion_r2936696123
##########
foreign/csharp/Iggy_SDK/IggyClient/Implementations/TcpMessageStream.cs:
##########
@@ -728,7 +728,7 @@ public async Task ChangePassword(Identifier userId, string
currentPassword, stri
throw new NotConnectedException();
}
- var message = TcpContracts.LoginUser(userName, password, "0.5.0",
"csharp-sdk");
+ var message = TcpContracts.LoginUser(userName, password,
SdkVersion.Value, "csharp-sdk");
Review Comment:
for now this is fine, but in future you'll insert a actual binary protocol
crate version. can you make it a TODO? it'll be embedded into all libs during
compilation step. (or hardcoded).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
