chengxilo commented on code in PR #2964:
URL: https://github.com/apache/iggy/pull/2964#discussion_r2954743472
##########
foreign/go/contracts/client.go:
##########
@@ -17,6 +17,8 @@
package iggcon
+import "context"
+
type Client interface {
// Close closes the client and releases all the resources.
Close() error
Review Comment:
I think conn.Close() just closes the socket and isn't a blocking network I/O
operation. And `Close() error` is a standard Go idiom if I am not mistaken(it
implement `io.Closer`), I think it's okay to leave it as-is without additional
documentation.
##########
foreign/go/contracts/client.go:
##########
@@ -17,6 +17,8 @@
package iggcon
+import "context"
+
type Client interface {
// Close closes the client and releases all the resources.
Close() error
Review Comment:
I think conn.Close() just closes the socket and isn't a blocking network I/O
operation. And `Close() error` is a standard Go idiom if I am not mistaken(it
implements `io.Closer`), I think it's okay to leave it as-is without additional
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
