spetz commented on issue #19: URL: https://github.com/apache/iggy/issues/19#issuecomment-4085145349
IMO it'd be great if we could simply use the existing `Stats` struct (exposed under `GET /stats` and also available for all other transport protocols as well), and extend the existing `/metrics` (which are now of a different kind). Eventually we could even merge these together at some point if it makes sense to avoid the confusion. The only thing to keep in mind is the authentication - `stats` requires authn/z to be invoked, while for `metrics`, since it'd be just exposed with HTTP, we could add some configurable `token/api-key` so that when prometheus is scraping the data, it could use something like `GET /stats?token=secret123`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
