lukaszzborek commented on code in PR #2948:
URL: https://github.com/apache/iggy/pull/2948#discussion_r2961667343
##########
foreign/csharp/Iggy_SDK.Tests.BDD/Context/TestContext.cs:
##########
@@ -25,8 +25,12 @@ public class TestContext
{
public IIggyClient IggyClient { get; set; } = null!;
public string TcpUrl { get; set; } = string.Empty;
+ public string LeaderTcpUrl { get; set; } = string.Empty;
+ public string FollowerTcpUrl { get; set; } = string.Empty;
+ public Dictionary<string, IIggyClient> Clients { get; set; } = [];
public StreamResponse? CreatedStream { get; set; }
public TopicResponse? CreatedTopic { get; set; }
public List<MessageResponse> PolledMessages { get; set; } = new();
public Message? LastSendMessage { get; set; }
+ public string? InitialAddress { get; set; }
Review Comment:
`InitialAddress` is not used anywhere now (only set as null in
BeforeScenario)
##########
foreign/csharp/Iggy_SDK.Tests.BDD/StepDefinitions/LeaderRedirectionSteps.cs:
##########
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+using Apache.Iggy.Configuration;
+using Apache.Iggy.Contracts;
+using Apache.Iggy.Enums;
+using Apache.Iggy.Factory;
+using Apache.Iggy.IggyClient;
+using Reqnroll;
+using Shouldly;
+using TestContext = Apache.Iggy.Tests.BDD.Context.TestContext;
+
+namespace Apache.Iggy.Tests.BDD.StepDefinitions;
+
+[Binding]
+public class LeaderRedirectionSteps
+{
+ private readonly TestContext _context;
+ private readonly Dictionary<string, string> _clientInitialAddresses = [];
+ private readonly Dictionary<int, int> _clusterNodePorts = [];
+ private int _clusterNodeCount;
+
+ public LeaderRedirectionSteps(TestContext context)
+ {
+ _context = context;
+ }
+
+ [Given(@"I have cluster configuration enabled with (\d+) nodes")]
+ public void GivenIHaveClusterConfigurationEnabledWithNodes(int nodeCount)
+ {
+ _clusterNodeCount = nodeCount;
+ }
+
+ [Given(@"node (\d+) is configured on port (\d+)")]
+ public void GivenNodeIsConfiguredOnPort(int nodeId, int port)
+ {
+ _clusterNodePorts[nodeId] = port;
+ ResolveAddressForPort(port).ShouldNotBeNullOrEmpty();
+ }
+
+ [Given(@"I start server (\d+) on port (\d+) as (leader|follower)")]
+ public void GivenIStartServerOnPortAs(int nodeId, int port, string role)
+ {
+ _clusterNodeCount.ShouldBeGreaterThan(0);
+ _clusterNodePorts.TryGetValue(nodeId, out var
configuredPort).ShouldBeTrue();
+ configuredPort.ShouldBe(port);
+ var address = ResolveAddressForRole(role);
+ address.ShouldEndWith($":{port}");
+ }
+
+ [Given(@"I start a single server on port (\d+) without clustering
enabled")]
+ public void GivenIStartASingleServerOnPortWithoutClusteringEnabled(int
port)
+ {
+ _context.TcpUrl.ShouldEndWith($":{port}");
+ }
+
+ [When(@"I create a client connecting to (follower|leader) on port (\d+)")]
+ public async Task WhenICreateAClientConnectingToOnPort(string role, int
port)
+ {
+ var address = ResolveAddressForRole(role);
+ address.ShouldEndWith($":{port}");
+
+ await CreateAndConnectClient("main", address);
+ }
+
+ [When(@"I create a client connecting directly to leader on port (\d+)")]
+ public async Task WhenICreateAClientConnectingDirectlyToLeaderOnPort(int
port)
+ {
+ var address = _context.LeaderTcpUrl;
+ address.ShouldEndWith($":{port}");
+
+ await CreateAndConnectClient("main", address);
+ }
+
+ [When(@"I create a client connecting to port (\d+)")]
+ public async Task WhenICreateAClientConnectingToPort(int port)
+ {
+ var address = ResolveAddressForPort(port);
+ await CreateAndConnectClient("main", address);
+ }
+
+ [When(@"I create client ([A-Z]) connecting to port (\d+)")]
+ public async Task WhenICreateClientConnectingToPort(string clientName, int
port)
+ {
+ var address = ResolveAddressForPort(port);
+ await CreateAndConnectClient(clientName, address);
+ }
+
+ [When(@"I authenticate as root user")]
+ public async Task WhenIAuthenticateAsRootUser()
+ {
+ var client = GetClient("main");
+ var loginResult = await client.LoginUser("iggy", "iggy");
+
+ loginResult.ShouldNotBeNull();
+ loginResult.UserId.ShouldBe(0);
+ }
+
+ [When(@"both clients authenticate as root user")]
+ public async Task WhenBothClientsAuthenticateAsRootUser()
+ {
+ foreach (var clientName in _context.Clients.Keys.OrderBy(name =>
name).ToList())
+ {
+ var loginResult = await
_context.Clients[clientName].LoginUser("iggy", "iggy");
+ loginResult.ShouldNotBeNull();
+ loginResult.UserId.ShouldBe(0);
+ }
+ }
+
+ [When(@"I create a stream named ""([^""]+)""")]
+ public async Task WhenICreateAStreamNamed(string streamName)
+ {
+ _context.CreatedStream = await
GetClient("main").CreateStreamAsync(streamName);
+ }
+
+ [Then(@"the client should automatically redirect to leader on port (\d+)")]
+ public async Task
ThenTheClientShouldAutomaticallyRedirectToLeaderOnPort(int port)
+ {
+ await AssertClientAddress("main", port);
+
GetClient("main").GetCurrentAddress().ShouldNotBe(GetClientInitialAddress("main"));
+ }
+
+ [Then(@"the stream should be created successfully on the leader")]
+ public void ThenTheStreamShouldBeCreatedSuccessfullyOnTheLeader()
+ {
+ _context.CreatedStream.ShouldNotBeNull();
+ _context.CreatedStream.Name.ShouldNotBeNullOrEmpty();
+ }
+
+ [Then(@"the client should not perform any redirection")]
+ public void ThenTheClientShouldNotPerformAnyRedirection()
+ {
+
GetClient("main").GetCurrentAddress().ShouldBe(GetClientInitialAddress("main"));
+ }
+
+ [Then(@"the connection should remain on port (\d+)")]
+ public async Task ThenTheConnectionShouldRemainOnPort(int port)
+ {
+ await AssertClientAddress("main", port);
+ }
+
+ [Then(@"the client should connect successfully without redirection")]
+ public void ThenTheClientShouldConnectSuccessfullyWithoutRedirection()
+ {
+ GetClient("main").ShouldNotBeNull();
+
GetClient("main").GetCurrentAddress().ShouldBe(GetClientInitialAddress("main"));
+ }
+
+ [Then(@"client ([A-Z]) should (stay connected to|redirect to) port (\d+)")]
+ public async Task ThenClientShouldStayConnectedOrRedirectToPort(string
clientName, string expectation, int port)
+ {
+ await AssertClientAddress(clientName, port);
+
+ var currentAddress = GetClient(clientName).GetCurrentAddress();
+ var initialAddress = GetClientInitialAddress(clientName);
+
+ if (expectation == "stay connected to")
+ {
+ currentAddress.ShouldBe(initialAddress);
+ return;
+ }
+
+ currentAddress.ShouldNotBe(initialAddress);
+ }
+
+ [Then(@"both clients should be using the same server")]
+ public void ThenBothClientsShouldBeUsingTheSameServer()
+ {
+
GetClient("A").GetCurrentAddress().ShouldBe(GetClient("B").GetCurrentAddress());
+ }
+
+ private async Task CreateAndConnectClient(string name, string address)
+ {
+ var client = IggyClientFactory.CreateClient(new IggyClientConfigurator
+ {
+ BaseAddress = address,
+ Protocol = Protocol.Tcp,
+ ReconnectionSettings = new ReconnectionSettings { Enabled = true },
+ AutoLoginSettings = new AutoLoginSettings { Enabled = false }
+ });
+
+ await client.ConnectAsync();
+ await client.PingAsync();
+
+ _context.Clients[name] = client;
+ _clientInitialAddresses[name] = address;
+ if (name == "main")
+ {
+ _context.IggyClient = client;
+ }
Review Comment:
_context.IggyClient is not used in this scenarios. I think this code can be
remove (setting client to _context.IggyClient)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
